Yair Zaslavsky has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 1092: ArrayList<RpmVersion> isos =
(ArrayList<RpmVersion>) returnValue;
Line 1093: if (isos.size() > 0)
Line 1094: {
Line 1095: VDS vds =
hostGeneralModel.getEntity();
Line 1096: String [] host =
vds.getHostOs().split("-"); //$NON-NLS-1$ //$NON-NLS-2$
Unfortunately, hostOs is not stored in rpm version format at database.
We should consider fixing this if possible (at getCaps handling).
Line 1097: hostGeneralModel.setHasUpgradeAlert(
Line 1098: shouldAlertUpgrade(
Line 1099: isos,
Line 1100: new Version(
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
