Alon Bar-Lev has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 1098: hostGeneralModel.setHasUpgradeAlert(
Line 1099: shouldAlertUpgrade(
Line 1100: isos,
Line 1101: new Version(
Line 1102: new
StringBuilder(NodeRPMVersion).append(
I don't think there is much difference between + and StringBuilder these days.
But anyway, you do not need the extra NodeRPMVersion variable, and even if you
do, it should not start with capital, right? And if you do, you do not need to
create another string builder...
Line 1103: host[1].trim()
Line 1104: ).append(".").append(
//$NON-NLS-1$ //$NON-NLS-2$
Line 1105:
host[2].split("\\.")[0].trim() //$NON-NLS-1$ //$NON-NLS-2$
Line 1106: ).toString()
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
