It isn't especially dangerous or nasty but it shuts valgrind up and makes processing its output a hell of a lot easier. Before the patch valgrind gives two errors about uninitialised data, afterwards she is happy. Anyway, what's the harm in initialising it? Now at least I know the errors are my own.
Alastair On Tue, 2005-12-06 at 16:14 +0000, Mike Frysinger wrote: > On Wed, Dec 07, 2005 at 03:02:45AM +1100, Alastair Poole wrote: > > Enclosed is a small patch that stops valgrind from bitching with every > > application that links against evas. > > > --- e17/libs/evas/src/lib/engines/common/evas_font_draw.c 2005-12-03 > > 20:35:21.000000000 +1100 > > +++ e17/libs/evas/src/lib/engines/common/evas_font_draw.c.new > > 2005-12-07 02:41:14.000000000 +1100 > > @@ -4,7 +4,7 @@ > > evas_common_font_int_cache_glyph_get(RGBA_Font_Int *fi, FT_UInt index) > > { > > RGBA_Font_Glyph *fg; > > - char key[6]; > > + char key[6] = {0}; > > FT_Error error; > > > > key[0] = ((index ) & 0x7f) + 1; > > how exactly is this a fix ? > -mike > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel