On Wed, Dec 07, 2005 at 03:44:21AM +1100, Alastair Poole wrote: > It isn't especially dangerous or nasty but it shuts valgrind up and > makes processing its output a hell of a lot easier. Before the patch > valgrind gives two errors about uninitialised data, afterwards she is > happy. Anyway, what's the harm in initialising it? Now at least I know > the errors are my own.
why pepper the source code with obvious work arounds for a tool that appears to be broken read the code, just *two* lines below the line you changed, the key variable is clearly initialized > > > - char key[6]; > > > + char key[6] = {0}; > > > FT_Error error; > > > > > > key[0] = ((index ) & 0x7f) + 1; -mike ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel