Wow, turns out this was a big misunderstanding, the docs for "step_set" were confusing and I got the wrong end of the stick!
Instead of the elaborate plan above I will change the "step" parameter to "grow_step" in init and in step_set and write some meaningful docs. With that the meaning should be clear enough. Apologies for the noise, Andy On Thu, 16 Nov 2017 at 11:00 Andrew Williams <a...@andywilliams.me> wrote: > Hi, > > Are there any objections to me: > > 1) changing the parameter name on array creation to "size" from "step" > 2) adding eina_array_size_set which additionally does not take a sizeof > param > 3) deprecate the eina_array_step_set as it's semantics are strange (as per > previous email). > > Thanks. > Andy > > On Tue, 14 Nov 2017 at 13:04 Andrew Williams <a...@andywilliams.me> wrote: > >> Hi, >> >> When talking about arrays my understanding that "step" typically refers >> to the number of items to jump when iterating (i.e. 1). However the eina >> docs use step on initialisation and on step_set to indicate "size" or >> "count". >> >> Additionally eina_array_step_set takes a parameter sizeof_eina_array >> which is documented to need to be sizeof(Eina_Array), but obviously the >> eina_array is the first parameter. Is there any reason why we have to pass >> that parameter? >> What I am wonder is - can't we just create "eina_array_size_set(uint)"? >> >> Thanks, >> Andy >> -- >> http://andywilliams.me >> http://ajwillia.ms >> > -- > http://andywilliams.me > http://ajwillia.ms > -- http://andywilliams.me http://ajwillia.ms ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
