Admittedly I still don't understand parameter 2. What is the point of
passing in a variable when it's value is required to be constant?
if (sizeof (Eina_Array) != sizeof_eina_array)
ERR("Unknow Eina_Array size ! Got %i, expected %i !\n"
Thanks,
Andy
On Thu, 16 Nov 2017 at 12:50 Andrew Williams <a...@andywilliams.me> wrote:
> Hi,
>
> Yeah, see my follow up, I got the wrong end of the stick so I will go fix
> the docs instead.
>
> Andy
>
> On Thu, 16 Nov 2017 at 12:40 Jérémy Zurcher <jer...@asynk.ch> wrote:
>
>> Hello,
>>
>> On Thursday 16 November 2017 11:00, Andrew Williams wrote :
>> > Hi,
>> >
>> > Are there any objections to me:
>> >
>> > 1) changing the parameter name on array creation to "size" from "step"
>>
>> this is not the size of the array that is set here,
>> but the # of array elements used to automatically grow or shrink.
>>
>> see eina_array_remove or eina_array_grow called from eina_array_push
>>
>> > 2) adding eina_array_size_set which additionally does not take a sizeof
>> > param
>>
>> that eina_array_size_set is weird,
>> the sizeof check is here to ... detect a wrong pointer I guess
>> plus if I'm not mistaken, it will silently leak if called on an non empty
>> array !
>>
>> > 3) deprecate the eina_array_step_set as it's semantics are strange (as
>> per
>> > previous email).
>> >
>> > Thanks.
>> > Andy
>> >
>> > On Tue, 14 Nov 2017 at 13:04 Andrew Williams <a...@andywilliams.me>
>> wrote:
>> >
>> > > Hi,
>> > >
>> > > When talking about arrays my understanding that "step" typically
>> refers to
>> > > the number of items to jump when iterating (i.e. 1). However the eina
>> docs
>> > > use step on initialisation and on step_set to indicate "size" or
>> "count".
>> > >
>> > > Additionally eina_array_step_set takes a parameter sizeof_eina_array
>> which
>> > > is documented to need to be sizeof(Eina_Array), but obviously the
>> > > eina_array is the first parameter. Is there any reason why we have to
>> pass
>> > > that parameter?
>> > > What I am wonder is - can't we just create
>> "eina_array_size_set(uint)"?
>> > >
>> > > Thanks,
>> > > Andy
>> > > --
>> > > http://andywilliams.me
>> > > http://ajwillia.ms
>> > >
>> > --
>> > http://andywilliams.me
>> > http://ajwillia.ms
>> >
>> ------------------------------------------------------------------------------
>> > Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > _______________________________________________
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> --- Hell'O from Yverdoom
>>
>> Jérémy (jeyzu)
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> --
> http://andywilliams.me
> http://ajwillia.ms
>
--
http://andywilliams.me
http://ajwillia.ms
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
