1) I have tested them. it works for me
2) you have reverted all the commits without telling what is wrong for
each commit
3) you behave, as always, as a dictator.
When I found some problems with a commit, I didn't change the commit, but
I gave my opinion and it leads to a fix, and not a revert of a commit
Can you please telle me why:
1) adding some comments in ecore_x_drawable leads to a problem
2) changing WIN32 to _MSC_VER does not work. It WORKS and it is NECESSARY
for mingw.
3) why the autoconf changes (I guess that's the main problem) does not
work for you
I remember a mail you posted, when there was the war between etk and ewl
(that you start, iirc), where you said that discussion was needed when
arguying. You didn't
follow your own advices.
So, I'm not going to revert immediatly your reverts. I'm waiting for your
answer. But I'm not going to let your reverts in the cvs. Contrary to you,
I'm trying to
argue first.
Vincent
PS: I'm really fed up with your behavior.
On Thu, 15 Mar 2007, Enlightenment CVS wrote:
Enlightenment CVS committal
Author : mej
Project : e17
Module : libs/ecore
Dir : e17/libs/ecore/src/lib/ecore_x
Modified Files:
Makefile.am ecore_x_drawable.c
Log Message:
Wed Mar 14 21:57:38 2007 Michael Jennings (mej)
Reverting changes; kindly test patches BEFORE applying them.
----------------------------------------------------------------------
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_x/Makefile.am,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -3 -r1.34 -r1.35
--- Makefile.am 15 Mar 2007 00:32:30 -0000 1.34
+++ Makefile.am 15 Mar 2007 07:57:43 -0000 1.35
@@ -2,14 +2,13 @@
INCLUDES = \
@Xcursor_cflags@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
@x_cflags@ \
-I$(top_srcdir)/src/lib/ecore \
-I$(top_srcdir)/src/lib/ecore_txt \
@@ -59,14 +58,13 @@
libecore_x_la_LIBADD = \
@Xcursor_libs@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
[EMAIL PROTECTED]@ \
@x_libs@ \
$(top_builddir)/src/lib/ecore/libecore.la \
$(top_builddir)/src/lib/ecore_txt/libecore_txt.la \
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_x/ecore_x_drawable.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -3 -r1.2 -r1.3
--- ecore_x_drawable.c 15 Mar 2007 00:23:56 -0000 1.2
+++ ecore_x_drawable.c 15 Mar 2007 07:57:43 -0000 1.3
@@ -1,25 +1,13 @@
-/*
- * vim:ts=8:sw=3:sts=8:noexpandtab:cino=>5n-3f0^-2{2
- */
-
#include "ecore_x_private.h"
/**
- * @defgroup Ecore_X_Drawable_Group X Drawable Functions
- *
- * Functions that operate on drawables.
- */
-
-
-/**
* Retrieves the geometry of the given drawable.
* @param d The given drawable.
* @param x Pointer to an integer into which the X position is to be stored.
* @param y Pointer to an integer into which the Y position is to be stored.
* @param w Pointer to an integer into which the width is to be stored.
* @param h Pointer to an integer into which the height is to be stored.
- * @ingroup Ecore_X_Drawable_Group
*/
EAPI void
ecore_x_drawable_geometry_get(Ecore_X_Drawable d, int *x, int *y, int *w, int
*h)
@@ -47,7 +35,6 @@
* Retrieves the width of the border of the given drawable.
* @param d The given drawable.
* @return The border width of the given drawable.
- * @ingroup Ecore_X_Drawable_Group
*/
EAPI int
ecore_x_drawable_border_width_get(Ecore_X_Drawable d)
@@ -67,7 +54,6 @@
* Retrieves the depth of the given drawable.
* @param d The given drawable.
* @return The depth of the given drawable.
- * @ingroup Ecore_X_Drawable_Group
*/
EAPI int
ecore_x_drawable_depth_get(Ecore_X_Drawable d)
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
--
Ce message a été vérifié par MailScanner
pour des virus ou des polluriels et rien de
suspect n'a été trouvé.
Message délivré par le serveur de messagerie de l'Université d'Evry.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
