On Thursday, 15 March 2007, at 08:42:31 (-0500), Brian Mattern wrote: > The correct response to a dev breaking cvs is "hey, this broke, can > you fix it?"
If the breakage is minor, I agree 100%. But in this situation, every single project that used ecore was broken. There are times when it has been necessary to revert big breakages until the person who broke it has a chance to fix it. raster's done it, I've done it...heck, you've even probably done it. > Not everyone is in #e (its hard to take that mindless drivel for > more than a few minutes a month). So, "see #e" is a worthless > response. I don't agree. Generally speaking, when build problems arise, that's the first place they show up. And as a result, that's where they get discussed typically. > Now, several people having build issues does indicate that the build > is broken. But, people temporarily break cvs all the time (including > me, raster, and possibly even your holiness). Sure, we've all broken CVS. Sometimes in small ways, and sometimes in big ways. The little breakages aren't an issue, but if I broke a core library badly enough to not allow 90% of the stuff in CVS to compile, I'd expect my changes to be reverted too. > Either fix it or wait for the dev who broke it to fix it. (Or revert > your local tree to before the patch that broke things). I felt that the seriousness of the issue and the fact that none of those experiencing it seemed able to pinpoint the problem (it was admittedly misleading since ecore itself built and functioned fine) warranted backing out the changes until caro had a chance to fix his patch. I apologize for pissing people off, but I still feel that reverting the patch was the most expeditious solution. > I) Stop treating people like shit. I did not insult or degrade anyone. Nothing I did was personal or intended to be offensive. When I have time to dig into problems and help resolve them, I try to do so. But it just so happens that several people had broken builds, myself included, at a time when I was in the middle of too many things at once to try and track down the problem. So I fixed it quickly and waited for caro to return to discuss the problem. Unfortunately, he took it personally, and as I told him privately, it was not personal at all. Most of his changes are great, and I respect his ability. This one just happened to be a doozie. > II) Let them know when they break things BEFORE you revert their > changes. Normally I do. We have CVS for a number of reasons, and one if them is so that we have the ability to revert bad changes if necessary. A quick look shows at least 20 or so commit messages since November of patches that got reverted (instead of fixed) until a better or more correct fix could be applied. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) ----------------------------------------------------------------------- "A lot of times, men do things they don't want to do so the woman they're going out with will do things *they* don't want to do." -- Tim Allen ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
