Nick Hughart wrote: > Sebastian Dransfeld wrote: >> There is an icon cache with 100 icons. Latest used icons are prepended >> to the list. If an icon is in the cache, the cache does help. >> >> So for a scenario where a user only triggers efreet_icon through f.ex. >> a small favorite menu in e17, the cache is good. But if the modules >> menu is accessed it will blow the cache. So the cache should have a >> method to weigh which icons are most used. >> > For one, why is it limited to 100 icons?
Just a random number, as I have not done any tests on how much memory the icon cache uses, and I have no idea how many icons there are in use in a typical e17 session. > I can see this overflowing > fairly easy in E as it is now and this doesn't even include mime icons. > With my tests I haven't seen the cache come into play at all, the time > between searching for icons once and searching for that same set again > results in nearly identical times. This is when searching for mimetype > icons and unless the cache doesn't cover the searching this does I'd > have to disagree that it has any useful effect. There aren't that many > mimetypes in /usr/lib either so I don't think I'm exceeding the 100 icon > limit in this case and actually this case should shine with this caching > system. I have only checked with limiting the icon list in one of the efreet tests. Could you send me your test code? Limiting the icon list in ef_icon_theme.c to 100 icons, and duplicating the icon search code: (first drop disk cache: echo 3 > /proc/sys/vm/drop_caches) First run : 0.390257 Second run: 0.032595 Sebastian ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel