On Thu, Jul 16, 2009 at 4:05 AM, Vincent Torri<[email protected]> wrote:
>
> Hey,
>
> As some of us want to release eina after the next freeze, we must be sure
> that the API will not change after the release.
>
> Below is my brief review with some comments. Other people must review it.
> It's important to have a stable API after the release. So we must change
> the API now if needed.
>
> Vincent
>
>  * eina_accessor : better name for eina_accessor_over() ? (_foreach like
>                    like eina_iterator ?)
>  * eina_rbtree : eina_rbtree_delete() renamed to eina_rbtree_free()) ? Or
>                  like eina_accessor : eina_rbtree_over() ? Or _foreach ?

ok

>  * eina_rectangle : eina_spans_intersect() is not in the good namespace,
>                     otherwise, I don't know if eina_rectangle module is
>                     really finished.

if it is or not does not matter, just rename. the sooner, the better.


>  * eina_stringshare : good (put the declaration of
>                       eina_stringshare_replace() in the header)

this is in eina_stringshare_inline.x (included in header).

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to