On Thu, Jul 16, 2009 at 9:05 AM, Vincent Torri<[email protected]> wrote: > > Hey, > > As some of us want to release eina after the next freeze, we must be sure > that the API will not change after the release. > > Below is my brief review with some comments. Other people must review it. > It's important to have a stable API after the release. So we must change > the API now if needed. > > Vincent > > * eina_accessor : better name for eina_accessor_over() ? (_foreach like > like eina_iterator ?) > * eina_array : good > * eina_benchmark : good > * eina_convert : good > * eina_counter : good > * eina_cpu : good > * eina_error : good
Today i checked the eina_error system for a project im doing and i saw: eina_error_msg_register() Why this function changed from eina_error_register to eina_error_msg_register? you register an error with some "constructor" parameter (in this case the msg) no need to add the "msg" on the function name or we will have to add every function's parameter to the function name then :) We could even replace all this _register() _unregister() with _new() _free() Regards > * eina_f16p16 : good > * eina_file : good > * eina_hash : good (put the declaration of eina_hash_djb2_len() > in the header) > * eina_inlist : good > * eina_iterator : good > * eina_lalloc : good > * eina_list : good > * eina_magic : good > * eina_main : good > * eina_mempool : good > * eina_module : eina_module_list_delete() renamed to > eina_module_list_flush() > * eina_rbtree : eina_rbtree_delete() renamed to eina_rbtree_free()) ? Or > like eina_accessor : eina_rbtree_over() ? Or _foreach ? > * eina_rectangle : eina_spans_intersect() is not in the good namespace, > otherwise, I don't know if eina_rectangle module is > really finished. > * eina_safety_checks : good > * eina_stringshare : good (put the declaration of > eina_stringshare_replace() in the header) > * eina_tiler : good > * eina_trash: good > > ------------------------------------------------------------------------------ > Enter the BlackBerry Developer Challenge > This is your chance to win up to $100,000 in prizes! For a limited time, > vendors submitting new applications to BlackBerry App World(TM) will have > the opportunity to enter the BlackBerry Developer Challenge. See full prize > details at: http://p.sf.net/sfu/Challenge > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
