On Thu, Jul 16, 2009 at 2:09 PM, Cedric BAIL<cedric.b...@free.fr> wrote: > Thanks for the review ! > > On Thu, Jul 16, 2009 at 9:05 AM, Vincent Torri<vto...@univ-evry.fr> wrote: >> * eina_accessor : better name for eina_accessor_over() ? (_foreach like >> like eina_iterator ?) > > Hum, we already have a EINA_ACCESSOR_FOREACH macro, it will perhaps > create some confusion, but despite that I don't mind changing this > one. > > <snip good> > >> * eina_module : eina_module_list_delete() renamed to >> eina_module_list_flush() > > Will do.
Done. >> * eina_rbtree : eina_rbtree_delete() renamed to eina_rbtree_free()) ? Or >> like eina_accessor : eina_rbtree_over() ? Or _foreach ? > > Don't like to call it free, as rbtree is an inlined data type, Eina > doesn't control it's allocation/destruction, but just provide helper > to do so. And in fact eina_rbtree_delete is just a postfix iterator > (without the cost of the iterator and the possibility to destroy the > tree without reequilibration). > >> * eina_rectangle : eina_spans_intersect() is not in the good namespace, >> otherwise, I don't know if eina_rectangle module is >> really finished. > > I don't think we use eina_spans_intersect yet (It could be used in > Evas), so we can rename it. No idea for the rename, perhaps Turran can > comment on it. > > <snip good> -- Cedric BAIL ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
