On Tue, 14 Sep 2010 21:18:58 +0900 Mike McCormack <mj.mccorm...@samsung.com> said:
> On 09/13/2010 08:46 PM, Gustavo Sverzut Barbieri wrote: > > > > Yeah... that's the kind of problem I said in the other mail thread > > that got disturbed by stupid GIT discussions :-/ See guys, not even > > GIT would help here :-/ > > The problem here isn't the revision control system, it's that > there's no systematic code review before code goes into SVN. if you want development to work at 1/4 the speed it does... then just keep suggesting that. :) code gets looked at partly by svn commit mails with diffs. if we literally stopped all changes by everything having to be in a patch queue and reviewed, we'd need a lot more manpower than we have - a lot more time, or frankly - a lot less will get done. instead we have lots of empirical testing going on day to day. we eat our own dogfood. every day. it's a different method. well at least i do, and a lot of other devs do too. review doesn't just magically catch all bugs. reading code and thinking of every possible permutation it could be used in is hard and invariably lots of things fall through the cracks. to have less fall through you have it reviewed by multiple people. but then any form of development speed drops through the floor. and then even if you write whole sets of unit tests for every possible permutation of usage of whatever is being changed (good luck - i know our test cases will be, if we can sensibly even write an automated test, be many times larger than efl currently is and still fall short). one example - your epoll patches. i've disabled them now. they broke elm quicklaunch. it totally didn't dawn on me that elm was doing some fun tricks with fork that your patch implicitly interacts with and breaks as it inherits the epoll fd from parent to child. wasn't found until there was actual empirical testing of that specific codepath. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
