Hey, I don't know ecore enough to commit it myself, but I still have a couple of comments: 1. Your patch includes both logic and formatting changes, please split to two different patches. 2. Please also include the changelog change in the same patch.
Also, if possible please also include a nice svn log message, for example: "Ecore ecore-x: Implemented the stub backlight support functions." Thanks, Tom. ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
