On Wed, Feb 9, 2011 at 3:50 PM, <mathieu.taillefum...@free.fr> wrote:
> Hey Tom,
>
> I don't know ecore enough to commit it myself, but I still have a couple
> of comments:
> 1. Your patch includes both logic and formatting changes, please split
> to two different patches.
>
> Two patches for three functions of fifteen lines each ? The formatting is
> changed because I had to add a single line on the top of the file and my
> emacs still does not want to format things the right way. Something is
> furiously wrong in my .emacs file.
He meant the following hunks in your patch:
@@ -82,7 +83,7 @@
int i;
Eina_Bool ret = EINA_FALSE;
- if ((crtc == Ecore_X_Randr_None) ||
+ if ((crtc == Ecore_X_Randr_None) ||
(crtc == Ecore_X_Randr_Unset))
return ret;
@@ -837,7 +838,7 @@
}
if (crtc_info)
XRRFreeCrtcInfo(crtc_info);
-
+
if (res)
XRRFreeScreenResources(res);
@@ -867,10 +868,10 @@
}
if (crtc_info)
XRRFreeCrtcInfo(crtc_info);
-
+
if (res)
XRRFreeScreenResources(res);
-
+
return ret;
#else
return Ecore_X_Randr_None;
You are basically removing trailing whitespaces. While this in general
is good, fixing formatting while adding a new feature is bad, it just
make it hard to review.
Thanks guys. Ok, it is clear now. I did not understand the meaning of logic
here and every time I work on code I try to avoid trailing whitespaces (emacs
has a mode for that) so I did it mechanically which in this case makes reading
harder.
I will split the patch into two patchs as requested and resubmit them.
regards
Mathieu
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
