Hey Tom, I don't know ecore enough to commit it myself, but I still have a couple of comments: 1. Your patch includes both logic and formatting changes, please split to two different patches.
Two patches for three functions of fifteen lines each ? The formatting is changed because I had to add a single line on the top of the file and my emacs still does not want to format things the right way. Something is furiously wrong in my .emacs file. I do not know what do you mean about logic. Could you be more precise. The only thing I find too rigid is to separate the patch into two patches. It is very short, so I did not feel like to separate it into two parts 2. Please also include the ChangeLog change in the same patch. I Will do it. Also, if possible please also include a nice svn log message, for example: "Ecore ecore-x: Implemented the stub backlight support functions." fine by me. Mathieu. ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
