Thank you all! I'll consider that APIs be added as you mentioned.
In coding convention, I tried to keep the rule, but there was some mistakes because of unfamiliarity. :'-( Thank you for your fix. On Wed, Sep 21, 2011 at 7:47 PM, Daniel Juyung Seo <seojuyu...@gmail.com>wrote: > Sangho Park committed this patch. Thanks. > > By the way Kim Yunhan, I think it will be better to separate patches > for each feature. > Sangho Park separated the commits. Thanks! > http://trac.enlightenment.org/e/changeset/63509 > http://trac.enlightenment.org/e/changeset/63510 > > And as Chuneon Park mentioned, I think it will be also good if we can > configure the PINCH_ZOOM_MIN/MAX by API. > > I modified elm_map.c after Sangho Park's commit due to the coding > convention. > Please refer it. > http://trac.enlightenment.org/e/changeset/63513 > > Anyhow, thanks for your patch! > > Daniel Juyung Seo (SeoZ) > > > > > On Tue, Sep 20, 2011 at 12:20 PM, sangho park <gouach...@gmail.com> wrote: > > @soez > > sorry for late reply... > > > > i just review & test this patch. > > for me... this patch is fine. > > > > @yunhan > > thanks for your contribution of elm_map... :) > > i expect yunhan's cool activity for elm_map. > > > >> From: Daniel Juyung Seo <seojuyu...@gmail.com> > >> Subject: Re: [E-devel] a bug fix for zoom-out in elm_map > >> To: Enlightenment developer list > >> <enlightenment-devel@lists.sourceforge.net> > >> Message-ID: > >> < > cakco4m6g4kfcyfljygg09z1onvrpcmu9dyp+jqg8w9za8r7...@mail.gmail.com> > >> Content-Type: text/plain; charset=ISO-8859-1 > >> > >> Dear Kim Yunhan, > >> Thanks for you patch. > >> > >> Watchwolf and gouache can review your patch well. But I think nobody > >> are active now. > >> I just applied your patch and ran elementary_test "Map". > >> > >> I GUESS broken tile on zooming out issue is fixed. (I'm not sure we're > >> talking about the same issue.) > >> But I got noise on zooming out. > >> Please see this screenshot. > >> http://www.flickr.com/photos/67308399@N05/6128438625/ > >> > >> Black noise didn't happen before. > >> You can easily see this when you run elementary_test with valgrind. > >> Because it makes things very slow :) > >> > >> Can you check this? > >> Thanks in advance. > >> > >> Daniel Juyung Seo (SeoZ) > >> > >> > >> On Thu, Sep 8, 2011 at 4:43 PM, Kim Yunhan <spb...@gmail.com> wrote: > >>> Is there anybody to review this patch? > >>> :'-( > >>> > >>> On Tue, Sep 6, 2011 at 2:41 AM, Kim Yunhan <spb...@gmail.com> wrote: > >>> > >>>> > >>>> Hello. > >>>> > >>>> I wrote a patch that handles a bug while zooming-out in elm_map. > >>>> When I try to zoom out, some tiles are broken. > >>>> But it is hard to notice because broken frame disappears quickly. > >>>> > >>>> I investigated in a few days. > >>>> And I realize that there are something wrong. > >>>> When map is zoomed out, a tile is shrunk by evas_object_resize(). > >>>> But evas_map handles its texture by just its origin image size not a > shrunk > >>>> size. > >>>> If evas_object's width & height is shrunk, I have to handle for its > >>>> texture. > >>>> So, I added some code for patch. > >>>> > >>>> Please review this. > >>>> Thanks! > >>>> > >>> > ------------------------------------------------------------------------------ > >>> Doing More with Less: The Next Generation Virtual Desktop > >>> What are the key obstacles that have prevented many mid-market > businesses > >>> from deploying virtual desktops? ? How do next-generation virtual > desktops > >>> provide companies an easier-to-deploy, easier-to-manage and more > affordable > >>> virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > >>> _______________________________________________ > >>> enlightenment-devel mailing list > >>> enlightenment-devel@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>> > >> > >> > >> > >> ------------------------------ > >> > >> > ------------------------------------------------------------------------------ > >> Why Cloud-Based Security and Archiving Make Sense > >> Osterman Research conducted this study that outlines how and why cloud > >> computing security and archiving is rapidly being adopted across the IT > >> space for its ease of implementation, lower cost, and increased > >> reliability. Learn more. > http://www.accelacomm.com/jaw/sfnl/114/51425301/ > >> > >> ------------------------------ > >> > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > >> > >> End of enlightenment-devel Digest, Vol 65, Issue 34 > >> *************************************************** > >> > > > ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
