It makes sense that nobody noticed it given that it only happens for values that are EXTREMELY close to 1.0, and you would really have to be looking for this bug in order to find it. Anyway, good to know that this will no longer be an issue!
On Mon, May 7, 2012 at 1:52 AM, Cedric BAIL <cedric.b...@free.fr> wrote: > On Sun, May 6, 2012 at 10:34 PM, Michael Blumenkrantz > <michael.blumenkra...@gmail.com> wrote: > > 0.999987 consistently returns a value greater than 1.0 when using > > ECORE_POS_MAP_ACCELERATE. > > > > On Sun, May 6, 2012 at 1:11 PM, Carsten Haitzler <ras...@rasterman.com > >wrote: > >> On Sun, 6 May 2012 12:50:27 +0000 Michael Blumenkrantz > >> <michael.blumenkra...@gmail.com> said: > >> > >> ummm... i suspect a bug in your code. that accelerate mode has been in > >> edje for > >> years - ecore just copied the algorithm/code out into a shared func in > >> edje. > >> i've had test code for it - here is the dump of values "near 1": > >> > >> 0.909 -> 0.857 > >> 0.919 -> 0.874 > >> 0.929 -> 0.889 > >> 0.939 -> 0.904 > >> 0.949 -> 0.922 > >> 0.960 -> 0.936 > >> 0.970 -> 0.951 > >> 0.980 -> 0.969 > >> 0.990 -> 0.984 > >> 1.000 -> 0.999 > >> > >> never goes above 1. > > There was a rouding and overflow issue in eina fixed point > implemantation of sin/cos that when getting close to 1 and above > 0.999, it could wrongly round the value and think it was above 1.0. It > is now fixed, I just don't really get why no one noticed that before > as we use that in edje intensively. > -- > Cedric BAIL > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel