Hi, Please review the attached patch after fixing review comments. Change Description: 1. Support for Multisense initialization/shutdown only when multisense feature is used. 2. Enhancement to _edje_multisense_shutdown to fix memory leak. 3. Multisense example enhancement and correction of macros(ENABLE_MULTISENSE & HAVE_REMIX) use in edje_multisense.c. 4. Interface multisense_factory_shutdown implementation, Macro WRN implementation using eina_log. 5. Fix for buffer underrun in ALSA plugin and REMIX flags are used in src/bin/Makefile.am. 6. Multisense support enabled by default. 7.Pulse Audio Remix Plug-in added as audio output device.
Signed-Off-By: Prince Kr Dubey<prince.du...@samsung.com> Thanks & Regards, Prince -------------------------------------------------- From: "Flavio Ceolin" <flavio.ceo...@profusion.mobi> Sent: Tuesday, June 26, 2012 11:19 PM To: "Enlightenment developer list" <enlightenment-devel@lists.sourceforge.net> Subject: Re: [E-devel] [Patch] [Edje] Added: Pulseaudio remix plug-in for edje multisense module > Hi Prince, > > On Tue, Jun 26, 2012 at 11:47 AM, Prince Kr Dubey > <prince.du...@samsung.com> wrote: >> Hi Flavio, >> >> I'll create another patch with the modification suggested by you and >> Gustavo. >> And will post the same to community ASAP. >> >> Thanks & Regards, >> Prince >> >> On 06/25/2012 14:20:20 , Flavio Ceolin <flavio.ceo...@profusion.mobi> >> wrote: >>> Hi Prince, >>> >>> Gustavo Sverzut Barbieri <barbi...@profusion.mobi> writes: >>> >>>> On Thu, Jun 21, 2012 at 10:32 AM, PRINCE KUMAR DUBEY >>>> <prince.du...@samsung.com> wrote: >>>>> Hi, >>>>> >>>>> Please find my query/comments inlined below. >>>> >>>> Ok, and could you use some email client that does proper reply? It's a >>>> mess and unusual to read your mails without the proper quote blocks. >>>> >>>> >>>>>> +EAPI extern Eina_Bool _on_edjecc; >>>>>> >>>>>> It seems to be not necessary. >>>>>> [Prince] this variable is required, in order to provide check to >>>>>> unnecessary multisense framework initialization during EDC >>>>>> compilation/decompilation mode. >>>>>> So, during EDC compilation, _on_edjecc=EINA_TRUE in edje_cc.c and >>>>>> hence, >>>>>> _edje_multisense_init() is being ignored in edje_main.c. >>>>> >>>>> >>>>> No, never do this. >>>>> >>>>> One should have a global setter and maybe a getter to enable or >>>>> disable >>>>> features, or even better just load multisense if it's required. >>>>> >>>>> [Prince] Multisense load is not needed during >>>>> compilation/decompilation, because it inculdes remix and its >>>>> plug-in(i.e. eetsndreader, ALSA) load, which are specificaly >>>>> required during runtime only. >>>>> As per your suggestion above, should we add interfaces for >>>>> setter/getter to enable this feature in edje ? Please share your >>>>> opinion. >>>> >>>> I dislike having to manually enable or disable them. Just use it as >>>> last resource. >>>> >>>> Ideally the multisense would be disabled and whenever a group uses >>>> multisense, it would be enabled. You do not need to further disable >>>> the setup later, it's fine to keep it on. >>>> It's like a lazy-loaded singleton. >>>> >>>> As edje_cc will never edje_object_file_set() it will never hit the >>>> path to load multisense. Then we're fine for it and every other >>>> software that does not use it. >>> >>> Are you intending to do the modifications suggested ? >>> Your patch with those modifications looks pretty good. >>> >>> Best Regards, >>> Flavio Ceolin >> >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > Thanks !! > > Best Regards, > Flavio Ceolin > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
edje_multisense_pulseaudio_plugin.patch
Description: Binary data
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
