Hi Prince, On Mon, Jul 9, 2012 at 3:50 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 06 Jul 2012 14:59:52 +0000 (GMT) PRINCE KUMAR DUBEY > <prince.du...@samsung.com> said: > >> >> Hi, >> >> >> -------------------------------------------------- >> >> From: "Carsten Haitzler (The Rasterman)" <[1]ras...@rasterman.com> >> >> Sent: Friday, July 06, 2012 1:38 PM >> >> To: "Enlightenment developer list" >> >> <[2]enlightenment-devel@lists.sourceforge.net> >> >> Cc: "PRINCE KUMAR DUBEY" <[3]prince.du...@samsung.com> >> >> Subject: Re: [E-devel] [Patch] [Edje] Added: Pulseaudio remix plug-in for >> edje multisense module >> >> >> > On Mon, 02 Jul 2012 07:07:19 +0000 (GMT) PRINCE KUMAR DUBEY >> >> > <[4]prince.du...@samsung.com> said: >> >> > >> >> > these are really suspicious. you're messing with starting/stopping >> >> > mainloops here.... >> >> > >> >> > + ecore_main_loop_quit(); >> >> > >> >> > + //again main loop begins to process thread cancellation >> >> > + ecore_main_loop_begin(); >> >> > >> >> > :( not good. imagine u shut down edje while still in the mainloop. :) >> >> > (not relevant for elementary but for things using raw edje+ecore+evas/ >> etc. >> >> > ...) >> >> Anyway in ecore_thread_cancel callback extra ecore_main_loop is being >> quit, >> So will it still be problem! >> >> Reason for using ecore_main_loop_begin is that ecore_thread_cancel/end >> callbacks are not getting called in _edje_multisense_shutdown (for memory >> cleanup purpose). >> >> So, begining the main loop again to cleanup the memory in >> ecore_thread_cancel. >> >> I have altrenate approach to free the memory, when control comes out from >> "while loop" in worker thread, is this approach is ok ? > > alternative approach definitely... not the ecore mainloop begin and quit > thing :) > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Besides the problem with the main_loop pointed out by raster, i've found some small issues in the patch. I've attached your patch with the review. Overall, the patch is working properly :) Regards, Flavio Ceolin
edje_multisense_pulseaudio_plugin.patch.review
Description: Binary data
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
