Hi Christophe, On Wed, Jul 11, 2012 at 09:41:55PM +0900, Christophe Sadoine wrote: > On 11 July 2012 14:36, Vincent Torri <[email protected]> wrote: > > On Wed, Jul 11, 2012 at 7:22 AM, Christophe Sadoine <[email protected]> > > wrote: > >> On 11 July 2012 13:56, Vincent Torri <[email protected]> wrote: > >>> beside the fact that you didn't add @since in the doc, that you didn't > >>> update ChangeLog and NEWS, a quaternion can represent a rotation in a > >>> 3D vector space if it is a unit quaternion. It's not mentioned in the > >>> doc, nor tested in the code. Is it normal ? > >> > >> Well it's just that I didn't think about it. We can put it in the doc > >> like you said, or we can normalize the quaternion in the function. > >> Which way is preferable? > > > > I think that the doc should mention that. Indeed, there is a big > > chance that if a user wants to do a rotation, he has angles, hence an > > already normalized quaternion. > > Here is the updated patch. I am not sure if I should fill the NEWS > file but I did. > Also I put @since 1.7 but I am not sure how to get the next version number. >
Can you update the doc replacing composante by some english word? Besides, the param doc could be improved a bit, mentioning the measure unit and so on - similar to evas_map_util_3d_rotate(). Regards... -- Leandro Dorileo ProFUSION embedded systems http://profusion.mobi ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
