On Fri, 28 Sep 2012 17:41:37 +0200 rustyBSD <rusty...@gmx.fr> said: > Le 28/09/2012 12:39, Carsten Haitzler (The Rasterman) a écrit : > > you're waiting for vincent to commit patches? what patches? where? by who? > > doing what? you planned to do something ... but never mention you did it. > > planning and doing are very different things. you didn't say that the > > patches you sent fix this. sorry but your mails are incredibly far from > > being clear on the topic. your first reply to me definitely is not. and > > then its "revert changes" which of course i refused as it'd make the code > > worse. > > > > could you please actually be clear before resorting to swearing and asking > > for reverts? > > You're not doing (overwrite_count) passes, > but (overwrite_count*NB_PASS). You cannot > cancel operation and see progression. > > Here is a patch. > > $ svn update -r77020 e_fm_op.c > And then patch. > > So we are doing the same thing (I mean, in > a loop), but correctly. (and ...random_buf() > never returns -1, so -> void).
yes. in fact i was wondering why this func could/should fail. you could always just use rand() anyway and it will never fail. :) > Discomfitor asked me to improve e_fm_op.c, > and I started by adding this little feature. > > It's just that it make me angry when I'm in > charge of something which is modified by others > without asking anything. Then I loose my time to > write mails, as if I had only that to do. here's a ground rule. no one is officially "in charge" in that they are the only one who can o should commit to something. it is a general guideline that you don't stomp around on code you don't know or understand, but anyone is free to fix or improve anything they want. there are no monopolies. if you do things in private (be it a private git repo + branchs you keep privately or patches you kep pricate) then those will get stomped on as no one knows what you are doing. send your patches to the list in public and... we then all know! if you had sent the patch with your reply i would not have changed the code - i likely may have committed it. :) in fact tht is just what i did. :) your patch is now in. thanks! just keep in mind. 1. be clear. 2. if you want others to know what you are doing - share it with them. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ How fast is your code? 3 out of 4 devs don\\\'t know how their code performs in production. Find out how slow your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219672;13503038;z? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
