Hello.

On 02/05/16 21:49, Larry de Oliveira Lira Jr wrote:
> Hi
> I think you don't have a dbus-daemon running, in the current 
> eldbus-test (eldbus_test_eldbus_init.c) I found:
>

I have it running and the eldbus test cases worked fine before your 
promise change. After your change they crash.

Marcel told me on IRC that he had a look at the backtrace of the crash 
and ecore_main_loop_begin pointed to 0x0 because ecore was not linked 
correctly.

>  57 /* TODO: This test assumes an existing dbus-daemon running. It
>  58  * shouldn't do this, instead we should launch dbus-daemon ourselves
>  59  * and create our private instance, use it and then kill it
>  60  * afterwards.
>  61  */
>
> and almost of eldbus test is disabled/commented
>
> I think the best is deactivate this eldbus tests added by me, until I 
> found a best solution
>

You did not add new tests but changed some that already have been there 
and are now longer working now. Deactivating them is no solution. Please 
get this fixed.

This is not even all this commit broke. You use ecore_promise_then and 
ecore_promise_value_get here while these function do not exist (its 
eina_ not ecore_) and the compiler happily warns you about it...

Please have a look and get these whole thing fixed. I feel close to 
reverting it but I want to give a chance first to get it sorted out.

regards
Stefan Schmidt

------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to