Hello. On 04/05/16 04:16, Felipe Magno de Almeida wrote: > > On May 3, 2016 10:46 PM, "Carsten Haitzler" <ras...@rasterman.com > <mailto:ras...@rasterman.com>> wrote: > > > > On Tue, 3 May 2016 11:19:35 +0200 Stefan Schmidt > <ste...@osg.samsung.com <mailto:ste...@osg.samsung.com>> said: > > > > > Hello. > > > > > > On 03/05/16 09:19, Stefan Schmidt wrote: > > > > Hello. > > > > > > Hello raster, > > > you're right stefan. disabling just to get new stuff in is wrong. > we've had > > problems with tests where on one machine they always succeed and on > another > > they fail randomly and we can't figure it out because they work for > developers. > > these are just cases we have to live with until we finally find out > why... > > > > but disabling tests just to avoid fixing something is wrong. > > > > i get is that new things come in and don't have tests yet - they may > never have > > tests because of their nature (because the tests are insanely > horrible to write > > or run). that's ok. not brilliant but ok. turning off tests that we > have ... > > unless the tests themselves just were invalid/wrong and unable to be > sanely > > run/tested... is not good. > > Larry wanted to disable the test until it found a fix, which i > corrected him because it doesn't help anybody passing tests by itself. > If it fails, better leaving it failing and just work on the fix asap > instead of commenting it. This makes it easier to see what is still > wrong before we release and we can use the information from being able > to reproduce the problem. He reverted the disabling of the tests. And > found the error that caused the segmentation faults and pushed add well. >
Just verified that it is working fine again. Same for Jenkins. Thanks for fixing this quickly. I might have sound a bit grumpy yesterday but every strange thing I touched pointed to this commit. :) Don't take it the wrong way, normally I'm only this grumpy shortly before a release. :) regards Stefan Schmidt ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
