Hello. On 03/05/16 17:06, Larry de Oliveira Lira Jr wrote: > hi Stefan, > > I assume the responsibility about error in Eio test, I think the > Felipe disable eio_model_monitor in initial development of promise and > I don't enable and corrected it >
Given that these tests kept disabled and the commit even brought in code that no longer is available (ecore_promise_) it tells me that both the developer and reviewer should pay more attention. > I can't reproduce you error in Eldbus test how you put in you first > mail, but I find 2 possibility > > 1) you dont have a dbus-daemon in you machine, or anything how it Let me repeat once again, I have dbus daemon installed and running. All eldbus tests have been running fine on my machine and Jenkins before the promise commit. > > 2) this is more complex situation and the reason to I disable the > Eldbus test, in test we do a dbus_fake_server to test more "right" > some things (how signals), if the test fail and the fake_server don't > close appropriately all next Eldbus test will fail, In my tests I only > stay in this situation by "force", and maybe any of you environment > stay the test in this situation. > > about dbus-daemon I don't know if is the case to do it now, I need see > with felipe, and about "fake-server" I'm trying make it more stable to > maybe enable te test again > > I disabled the Eldbus model test because I believed has a error in > test case, (the Eldbus test is still disabled) you think the correct > is enable it now? > How should it be ok now? There is something in this promise commit that breaks existing tests and it need to get fixed. regards Stefan Schmidt ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
