Hello. On 30/05/16 10:13, Stefan Schmidt wrote: > On 27/05/16 21:20, Jean Guyomarc'h wrote: >> Also, should 1.18 mark Ecore_Cocoa as stable? The discussion started >> before 1.17 was released, >> and no changes has been brought to the Ecore_Cocoa API, so it seems fine to >> me. > Fair enough. I will have look over the API this week and let you know > what I think. I would also like to see someone else looking over it as > well. Raster, Cedric, JP, Tom, anyone else?
I looked over Ecore_Cocoa.h now. Most of it looks sane and ready to me. here are just a couple of remarks. This one looks redundant to me ECORE_COCOA_CURSOR_DEFAULT = ECORE_COCOA_CURSOR_ARROW Why would we need a ECORE_COCOA_CURSOR_DEFAULT enum type? We could use the _ARROW instead of _DEFAULT in all cases I can think of. Maybe add a LAST type in Ecore_Cocoa_Cnp_Type enum as well to ease iteration? Line 196 copy and paste bug. how many times shutdown not init. What does ecore_cocoa_window_view_set() actually do? Just from the function name and docs I was not able to figure it out. Cocoa specifics? regards Stefan Schmidt ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
