Hello. On 07/06/16 21:39, Jean Guyomarc'h wrote: > Hi, > > ok, I'll change ECORE_COCOA_CURSOR_DEFAULT to make it a macro, > as it makes the code less akward. > > After making another pass on Ecore_Cocoa.h, I have some enlightened concerns: > > (1) the '__ECORE_COCOA_CURSOR_LAST' field in an enum. I like it, > because it makes > it so convenient to iterate over the whole enum values, create an > array that can hold > exactly all the fields in the enum, ... BUT I wonder about ABI > preservation if we need > to add fields in the enum. Plus, this is exposing extra stuff, which > value will change > as the enum is extended. I don't know what you guys are thinking of this...
We have such sentinels in enums in other parts of the code as well. I quick grep showed me at least emotion, ephysics, ecore_audio, eldbus, etc Yes, it changes when we add new real values to the enum but it is clearly marked as sentinel so this should be ok. > (2) ecore_cocoa_selection_clipboard_get() is just akward. The > concept of it returning a > void* which needs to be re-interpreted according to a second value > returned by address > is just so bad (mea culpa, mea maxima culpa). I think it has to be > nuked. It could very > well return a Eina_Value or an Eina_Array/Eina_Inarray of Eina_Values. If you could eliminate the void* as return that would be nice I would say. > (3) the ecore_cocoa_selection_clipboard_xxxx() functions should > maybe be renamed > ecore_cocoa_clipboard_xxxx() (dropping the "selection" inside). I'm > not quite sure why > I named them this way in the first place, but that seem odd: they have > nothing to do > with a selection, only with the clipboard. > > > Unless there is a "no go", I'll start with (3), because it is easy to > do and requires few changes. > I will wait for some feedback for (1). > I'll overhaul (2) with what I think is a better API, it should require > few changes to the > implementation, and wait for remarks. From the commit log I can see that 3 is done. For 1 and 2 you have been waiting for feedback? regards Stefan Schmidt ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
