Hi, any update?
Best regards, Jean On Wed, Jun 1, 2016 at 5:47 PM, Jean Guyomarc'h <jean.guyoma...@gmail.com> wrote: > Hi, > >> This one looks redundant to me >> ECORE_COCOA_CURSOR_DEFAULT = ECORE_COCOA_CURSOR_ARROW >> Why would we need a ECORE_COCOA_CURSOR_DEFAULT enum type? We could use >> the _ARROW instead of _DEFAULT in all cases I can think of. > > There are more X cursors than Cocoa cursors. > ECORE_COCOA_CURSOR_DEFAULT is used as a fallback when a cursor is > requested by an application, > but is not available. Maybe a #define would be more appropriate? > >> Maybe add a LAST type in Ecore_Cocoa_Cnp_Type enum as well to ease >> iteration? > > Mh.. I'm not sure about this one, because Ecore_Cocoa_Cnp_Type is not > supposed to > be iterated over. It just hold flags. > >> Line 196 copy and paste bug. how many times shutdown not init. > > Oops. Thanks. Will fix. > >> What does ecore_cocoa_window_view_set() actually do? Just from the >> function name and docs I was not able to figure it out. Cocoa specifics? > > In cocoa, a window (NSWindow) has a "content view" is the window > main container. This function allow to "set the contents of a window". > Maybe should I add a link to the cocoa documentation? > > Thanks for the review :-) > > Best regards, > Jean ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
