On 15 February 2017 at 08:42, Carsten Haitzler <[email protected]> wrote:
> On Tue, 14 Feb 2017 07:10:44 -0500 Christopher Michael < > [email protected]> > said: > > > Apologize for the incorrect fix there Jean-Philippe, hope I did not > > break things too badly for you :) > > that's ok. the code was misleading. it indented to do X but was structured > to > do Y... it's a fair enough confusion and one of these has to win out as the > correct path. :) > Haha. Your commit brought this line to my attention so in the end the code should be more readable. :) And I doubt this change has any impact (except for some debug logs). > > > Cheers, > > dh > > > > On 02/13/2017 09:13 PM, Jean-Philippe ANDRÉ wrote: > > > jpeg pushed a commit to branch master. > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id= > 45d846814f813b8575276edf0ee9586d7cd25ecc > > > > > > commit 45d846814f813b8575276edf0ee9586d7cd25ecc > > > Author: Jean-Philippe Andre <[email protected]> > > > Date: Tue Feb 14 10:54:32 2017 +0900 > > > > > > evas gl: Fix memory tracking > > > > > > See b16c961680579ad13 which by "fixing" indentation changed the > > > logic of the code. Yes the indentation was misleading (because of > > > the #if / #else) but the logic was correct. Anyway this is was not > > > a harmful issue as those memory trackers aren't really used. > > > --- > > > src/modules/evas/engines/gl_common/evas_gl_core.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/modules/evas/engines/gl_common/evas_gl_core.c > > > b/src/modules/evas/engines/gl_common/evas_gl_core.c index > 9eb4c0d..b50adfc > > > 100644 > > > --- a/src/modules/evas/engines/gl_common/evas_gl_core.c > > > +++ b/src/modules/evas/engines/gl_common/evas_gl_core.c > > > @@ -1344,8 +1344,8 @@ _surface_buffers_allocate(void *eng_data > EINA_UNUSED, > > > EVGL_Surface *sfc, int w, _renderbuffer_allocate(sfc-> > depth_stencil_buf, > > > sfc->depth_stencil_fmt, w, h, > > > sfc->msaa_samples); > > > - sfc->buffer_mem[3] = w * h * 4; > > > } > > > + sfc->buffer_mem[3] = w * h * 4; > > > } > > > else > > > { > > > > > > > > > > > ------------------------------------------------------------ > ------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Jean-Philippe André ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
