On Tue, 2006-07-11 at 09:28 -0400, Chris Toshok wrote: > No opinion on the rest of the patch, but this: > > > +static void > > +free_token (gchar *token) > > +{ > > + gint i=0; > > + gboolean no=FALSE; > > + > > + for (i=0; (i < tokens_len); i++) > > + { > > + if (tokens[i] == token) > > + no = TRUE; > > + } > > + > > + if (!no) > > + g_free (token); > > +} > > + > > is more efficient as: > > static void > free_token (gchar *token) > { > gint i; > > for (i = 0; i < tokens_len; i ++) > if (tokens[i] == token) > return;
out of curiosity, the first patch reads through the list and this patch, return if any one of the token is equal, anf not any following it. Would the below not be better ? for (i = 0; i < tokens_len; i ++) if (tokens[i] == token) break; -- Ritesh Khadgaray LinuX N Stuff Ph: +919822394463 Eat Right, Exercise, Die Anyway. _______________________________________________ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers