On Tue, Sep 26, 2006 at 11:20:13AM -0400, Don Zickus wrote: > On Tue, Sep 26, 2006 at 06:56:36PM +0530, Mohan Kumar M wrote: > > > > Attaching three kexec-tools patches to check whether the current kernel > > has reserved memory for crashkernel. The check is done by calling > > architecture dependent functions. If no memory is reserved for > > crashkernel, it displays appropriate error message and exits. > > > > PATCH 1: Checks for crashkernel memory reservation by calling > > architecture dependent function. It also creates dummy function for ppc, > > ia64 and s390 architectures to avoid problem in build process. > > > > PATCH 2: ppc64 specific crashkernel memory reservation check > > > > PATCH 3: i386 and x86-64 specific crashkernel memory reservation check > > > > Any suggestion, feedback? > > Pardon my ignorance, but why is there arch dependent functions to begin > with? This seems like it should be generic code? Yes, I read through the > ppc64 and i386/x86_64 patches and see both implementations are different, > but I also didn't see anything arch specific in either of those patches. >
Makes sense. Mohan, On ppc64 also can't we read presence of [EMAIL PROTECTED] from /proc/cmdline itself? Does it have to be read from device tree only? -Vivek _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
