#2763: Undo/Redo system porting from v2
-------------------------------+--------------------------------------------
 Reporter:  garry.yao          |       Owner:  garry.yao   
     Type:  New Feature        |      Status:  assigned    
 Priority:  Normal             |   Milestone:  CKEditor 3.0
Component:  General            |     Version:              
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 Garry, can you provide a new patch over the trunk this time?

 Also, I've noted the new "serializable" feature for the bookmarks. While
 the intention is good, it's not a good thing for us in this case. The undo
 system executes several times during the document lifetime. Using the
 current bookmarks, you are constantly adding nodes to the DOM.

 The above is not necessary as a undo snapshot is "stable". It contains a
 DOM tree and the selection position can safely be reconstructed by using
 the node counting system used in V2 (CreateBookmark2). So, I would do a
 step back an use that non intrusive bookmark system again.

 I'll go deeper on the review as soon as I'm able to patch the trunk with
 this.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2763#comment:4>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to