#2763: Undo/Redo system porting from v2
-------------------------------+--------------------------------------------
 Reporter:  garry.yao          |       Owner:  fredck      
     Type:  New Feature        |      Status:  assigned    
 Priority:  Normal             |   Milestone:  CKEditor 3.0
Component:  General            |     Version:              
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------

Comment(by garry.yao):

 Fred, the updated patch should has better performance due to the new
 bookmark system you adapted, and I also see the code quality improvement,
 it's a good example for me.
 Here, I just provide some of my opinions toward the logic details when
 performing the undo/redo, since I found in your patch many changes toward
 this part, some of which were those I introduced in my old patch to
 slightly distinguish the behaviors from v2 codes:

  1.  Either undo or redo only take care document modification along with
 selection changes, which mean stand-alone selection changes should not be
 recorded.
  1.  Undo record the snapshot right before a command, while redo record
 the snapshot right after it, both of themselves need not participant in
 snapshots.
  1.  Due-stacks mechanism was introduce for easy accessing snapshots
 according to the same history index,  though it could be combined, but is
 mistakable and complex during the navigation.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2763#comment:13>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to