Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qjackctl - Qt based JACK control application https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2006-05-12 00:28 EST ------- not a full review yet but some points you need to improve: - Package does not follow Fedora's package naming guildlines (wiki: PackageNamingGuidelines) release should be 1, 2, 3, not 2.0 - BuildRequires: desktop-file-utils is missing %define desktop_vendor planetccrma - desktop_vendor is fedora :) - add to desktop-file-install: --add-category X-Fedora # distros with 2.4.x kernels should use jackstart as the default %{?fc1:%define usejackstart 1} %{?rh9:%define usejackstart 1} - this define can go since extras doesn't go that far back -just use rm istead of %__rm macro -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
