Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: CGAL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199168 ------- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:58 EST ------- (In reply to comment #10) > > CGAL is a meta-package that requires CGAL-libs, CGAL-devel, and CGAL-sources. > > Contradicts Fedora conventions and IMNSOH, is complete non-sense. > Consider this to be a MUST FIX. > > Put the run-time libs into CGAL or CGAL-libs and the devel files into *-devel. For the moment (CGAL-3.2.1-14), libs are in CGAL-libs, and devel files are in CGAL-devel. > > > E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.sh > > > E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.csh > > > > As far as I know, these rpmlint errors should be ignored. > Nope, these scripts are incomplete. MUSTFIX Ok. I thought it was agreed that shell scripts in /etc/profile.d/ should not have shell bangs. If it is really a MUSTFIX, this should be written somewhere, and bugs should be reported, against all almost all package that ship something in /etc/profile.d/ > > (In reply to comment #8) > > > Further issues: > > > > > > - The *-devel package ships /usr/include/CORE > > > IMO, this directory name is too general. > > > > CGAL-3.2.1 ships CORE-1.7, http://www.cs.nyu.edu/exact/core_pages/intro.html > > This directory is from CORE. > And? This doesn't answer my remark. I do not see any solution, here. <CORE/...h> is the documented way to include CORE headers. If this is a blocker, CORE cannot be into Fedora. That's it. > > > - A more general design problem: > > > Some headers in /usr/include/CGAL hard-code configuration-time detected > > > * system features, e.g. the version of zlib and Qt > > > > > > * compiler characteristics, e.g. endianness. > > > > Yes, it should only be /usr/include/CGAL/compiler_config.h. Is it a blocker? > Well, there actually are 2 issues with this. > - Package dependencies. You will have to find a way to handle the hard-coded > version dependencies in rpm. Actually, these version macros are not used in CGAL. They are not even documented. They could be pruned. They are used by the CGAL test suite to display dependencies' versions. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedoraemail@example.com http://www.redhat.com/mailman/listinfo/fedora-package-review