Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225246 Jason Tibbitts <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Jason Tibbitts <[email protected]> 2008-12-19 13:23:56 EDT --- Here are some comments copied from my mailing list post: No %{?dist} tag, but I understand why you folks have no need of that. Is the source available for download anywhere? The Source0: URL should be downloadable if at all possible. The spec should at minimum include some instructions for checking out of an SCM. As of FC-5, it is not actually necessary to have: Requires(post): desktop-file-utils >= %{desktopfileutilsver} Requires(postun): desktop-file-utils >= %{desktopfileutilsver} as long as you use the recommended update-desktop-database scriptlets. http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database %post /usr/bin/update-desktop-database %{_datadir}/applications &> /dev/null || : %postun /usr/bin/update-desktop-database %{_datadir}/applications &> /dev/null || : Is there any reason to keep this bit: %triggerun -- anaconda < 8.0-1 /sbin/chkconfig --del reconfig >/dev/null 2>&1 || : Anaconda < 8.0 was, what, pre-RHL-8? There's some minor permission weirdness, like /usr/lib/anaconda-runtime/boot/syslinux.cfg and /usr/lib/anaconda-runtime/pyrc.py are executable, and also some shell scripts that don't have a shebang line like /usr/lib/anaconda-runtime/mk-images.s390. I'll spare everyone here the full listing; just run rpmlint and look at the script-without-shebang errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
