On 2013-11-26 09:29, Anders Logg wrote:
On Tue, Nov 26, 2013 at 10:22:40AM +0100, Marco Morandini wrote:
On 11/26/2013 10:22 AM, Garth N. Wells wrote:
>A fix for the STL std::nth_element bug in gcc 4.8.1 has been released
>for Ubuntu 13.10 as an update:
>
> https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1246802
>
>I suggest that we now remove the ifdefs for using boost::nth_element.
>The change was not made in a separate branch, so undoing it will require
>some digging. Anders: will you undo the change?
>
Don't assume that everyone out there is using Ubuntu.
You could consider adding a check at configure time
to detect the gcc bug.
Garth will claim that it has already been fixed since long on
Mac... ;-)
I won't claim anything. I can tell you. The bug didn't appear on OSX
with the latest Xcode, and it doesn't appear in Fedora or any other
distro that I'm aware of, besides Ubuntu 13.10.
But I didn't notice any difference in speed between the two
implementations and we already require boost so I think we can just
leave it as it is for now. At a later point when speed really becomes
an issue, we can check the benchmarks again and then decide which
implementation to use.
It's unnecessary code clutter, and we should strive to use STL over
Boost when practical.
Garth
--
Anders
_______________________________________________
fenics mailing list
[email protected]
http://fenicsproject.org/mailman/listinfo/fenics
