On 2013-11-26 10:20, Jan Blechta wrote:
On Tue, 26 Nov 2013 09:37:01 +0000
"Garth N. Wells" <[email protected]> wrote:
On 2013-11-26 09:22, Marco Morandini wrote:
> On 11/26/2013 10:22 AM, Garth N. Wells wrote:
>> A fix for the STL std::nth_element bug in gcc 4.8.1 has been
>> released for Ubuntu 13.10 as an update:
>>
>> https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1246802
>>
>> I suggest that we now remove the ifdefs for using
>> boost::nth_element. The change was not made in a separate branch,
>> so undoing it will require
>> some digging. Anders: will you undo the change?
>>
>
> Don't assume that everyone out there is using Ubuntu.
> You could consider adding a check at configure time
> to detect the gcc bug.
>
1. Which distributions are using unpatched GCC 4.8.1?
2. The proposal to check for gcc bugs is not, in general, sensible.
GCC has had many bugs that are fixed in subsequent releases. We have
never checked for these.
3. std::nth_element is used in DOLFIN dependencies, and we cannot fix
this, so using boost::nth_element is not general fix.
It seems that boost::nth_element calls std::nth_element according to
Nico's observation
https://bitbucket.org/fenics-project/dolfin/issue/156
So it is probably no fix at all. The confusion possibly comes from
another bugfix being done by Anders in BoundingBoxTree at the same time
which solved some similar issues.
I had a peek in boost/range/algorithm/nth_element.hpp, and it does
appear to call std::nth_element.
Garth
Jan
Garth
> Thanks,
>
> Marco
_______________________________________________
fenics mailing list
[email protected]
http://fenicsproject.org/mailman/listinfo/fenics
_______________________________________________
fenics mailing list
[email protected]
http://fenicsproject.org/mailman/listinfo/fenics
