On Tue, Nov 26, 2013 at 09:42:08AM +0000, Garth N. Wells wrote: > On 2013-11-26 09:23, Anders Logg wrote: > >On Tue, Nov 26, 2013 at 09:22:24AM +0000, Garth N. Wells wrote: > >>A fix for the STL std::nth_element bug in gcc 4.8.1 has been > >>released for Ubuntu 13.10 as an update: > >> > >> https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1246802 > >> > >>I suggest that we now remove the ifdefs for using > >>boost::nth_element. The change was not made in a separate branch, so > >>undoing it will require some digging. Anders: will you undo the > >>change? > > > >It's easy to undo. For a start, I suggest keeping the #ifdef and > >unsetting the flag. > > > >But why do we need to hurry to switch back to std::nth_element? > >It has not effect other than reintroducing the bug > > It never fixed the bug completely. CGAL code still failed because of > the STL bug. > > >for those who > >haven't yet upgraded gcc. > > I couldn't care less about users who won't run 'apt-get upgrade'. > > > > > Because it's code clutter and we should use STL rather than Boost > when possible.
I don't see it as a big problem and I'm maintaining that specific portion of the code. Can't we just keep it around for a few more weeks/months? Removing that code takes something like 30 seconds so it's not a big deal. -- Anders _______________________________________________ fenics mailing list [email protected] http://fenicsproject.org/mailman/listinfo/fenics
