On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote:
> Should fix ticket #6252
>
> Signed-off-by: James Almer <jamr...@gmail.com>
> ---
> libavformat/apngdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c
> index 7a284e32c2..75dcf74a0c 100644
> --- a/libavformat/apngdec.c
> +++ b/libavformat/apngdec.c
> @@ -421,7 +421,7 @@ static const AVOption options[] = {
> { "ignore_loop", "ignore loop setting" ,
> offsetof(APNGDemuxContext, ignore_loop),
> AV_OPT_TYPE_BOOL, { .i64 = 1 } , 0, 1 ,
> AV_OPT_FLAG_DECODING_PARAM },
> { "max_fps" , "maximum framerate (0 is no limit)" ,
> offsetof(APNGDemuxContext, max_fps),
> - AV_OPT_TYPE_INT, { .i64 = DEFAULT_APNG_FPS }, 0, INT_MAX,
> AV_OPT_FLAG_DECODING_PARAM },
> + AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM
> },
> { "default_fps", "default framerate (0 is as fast as possible)",
> offsetof(APNGDemuxContext, default_fps),
> AV_OPT_TYPE_INT, { .i64 = DEFAULT_APNG_FPS }, 0, INT_MAX,
> AV_OPT_FLAG_DECODING_PARAM },
> { NULL },why was there a max fps set ? are there files which have huge and incorrect fps ? if so this may cause a regression and just increasing the default value for max_fps could be better. If no such files exist then this LGTM wither way it needs a update to fate [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
