> > > > > + if (avctx->codec_id == AV_CODEC_ID_VP8) > > > + vp8_encode_set_roi(avctx, frame); > > > > The API only exists for VP8, or is this due to different quant scales or > > something? > > currently, VP9 ROI does not work, see my discussion at > https://groups.google.com/a/webmproject.org/forum/#!topic/codec-devel/HVBRjoW0fTw, > the issue is confirmed by libvpx, and I'm helping to verify their new patch > for the fix. >
It might be worth letting that conversation finish before pushing anything here. The API for VP9 hasn't changed, but there was a bug as you pointed out in that thread. > It is expected that VP9 ROI support will not be released in a short time, so > I just add for vp8 roi. > There is something common between VP8/VP9 ROI, and I plan to extract an > common function when doing the work for VP9 roi. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel