On Dec 16, 2003, at 1:27 PM, Benjamin Reed wrote:
David R. Morrison wrote:
There are a few other tweaks which are necessary as well. Fink is not
very smart about specifying the default choice, and in the automated
system, we always take the default choice. For this reason, I remove
the various system-foo packages before I start making the bindist.
(Will be less necessary in 10.3 since most system-foo package are now
virtual packages and needn't be added or removed.)
Not only that, but with Peter O'Gorman's recent match stuff, we could just have a couple of passes that match non-system packages:
MatchPackageRegEx: (^system-.*$)
Which should make this a bit easier... just have a "fink-pass1.conf" "fink-pass2.conf" etc that get used for each pass of the build, with different regexes.
Cute idea, but it doesn't work out of the box. If you look at the current implementation in Engine.pm:
1174 if (not $found) {
1175 # See if the user has a regexp to match in fink.conf
1176 my $matchstr = $config->param("MatchPackageRegEx");
1177 my $matchcount =0;
1178 my $usename;
1179 if (defined $matchstr) {
1180 foreach $dname (@candidates) {
1181 if ( $dname =~ $matchstr ) {
1182 $matchcount++;
1183 $usename = $dname;
1184 }
1185 }
1186 if (1 == $matchcount ) {
1187 $dname = $usename;
1188 $found = 1;
1189 }
1190 }
1191 }
If I have a choice of system-xfree86 xfree86 xfree86-base
and my regex excludes system-xfree86 I end up with a matchcount of 2. Thus nothing is done and I end up with all three choices. Thus I have to trim the candidates list to include only those dnames which match. Any objections if I change the code accordingly?
Cheers,
Remi
--------------------------------------------------------------------- Failure is not an option. It comes bundled with your Microsoft product. (Ferenc Mantfeld)
********************************************************************* Remigius K. Mommsen e-mail: [EMAIL PROTECTED] University of California, Irvine URL: http://cern.ch/mommsen c/o SLAC voice: ++1 (650) 926-3595 2575 Sand Hill Road #35 fax: ++1 (650) 926-3882 Menlo Park, CA 94025, US home: ++1 (650) 233-9041 *********************************************************************
------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
