On 09/11/2010 5:20 PM, David Lowe wrote: > Okeh, i guess i still need help. I see the PostInstScript in the > xinvaders info file, but i don't see where in it the offending > commands get edited out of the makefile. Isn't it normally done > using "sed"? FWIW, i'll include what i have so far for an info > file.
You can see the last revision of the xinvaders.patch file here: <http://fink.cvs.sourceforge.net/viewvc/fink/dists/10.4/unstable/main/finkinfo/games/xinvaders.patch?r1=1.1&r2=1.2> Because this was an actual removal of lines, a PatchFile was easier than a sed (or perl script). I removed the chgrp and chmod lines. The chmod could presumably have been kept, but I'm not sure how setuid reacts when the user/group of the underlying file is changed. It doesn't hurt, but it might not have been necessary. > 1) rearranged the blocks by phase so i can more easily find things > ;^) 2) removed "--with-setgid=games", the game builds and plays > without it! 3) changed "find lib/ -exec chown games:games {} \;" to > "find lib/ -exec chown games:games {} %p/lib;", i think this needs > more work, but it can wait until we get this past the --b-a-n > problem 4) The offending section of the makefile has: > > "# chgrp "" "$(DESTDIR)$(bindir)/angband" # chmod g+s > "$(DESTDIR)$(bindir)/angband" > > I'm still trying to grok percent expansion. Is it the case that > $(DESTDIR)$(bindir) should be replaced with %D? $DESTDIR is normally %d (ie /sw/src/fink.build/root-angband-3.0.6-3 $bindir is normally %p/bin (ie /sw/bin), so for the compound, you'd want %d/%p/bin or %i/bin (%i = %d/%p) In your InstallScript, all the chown commands will need to be moved to PostInstScript for angband to build when using --build-as-nobody. I'll let someone who better understands find say what the best way is. > With what do i replace the "" in chgrp?? Apparently, removing --with-setgid affects a whole lot of things (you can see this by searching for the string "SET_GID_TRUE" in the angband build directory). Given this, I'm not sure that just removing it will be the right solution. I'd be more tempted to try 1) setting that flag back the way it was, 2) deleting the above lines in Makefile.in via PatchFile, and 3) doing those commands in PostInstScript. If other commands still fail after this when trying to install as --build-as-nobody, they too can be patched and moved to PostInstscript. Hanspeter ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Fink-devel mailing list Fink-devel@lists.sourceforge.net http://news.gmane.org/gmane.os.apple.fink.devel Subscription management: https://lists.sourceforge.net/lists/listinfo/fink-devel
