Alexander,
The rational for the request to add these new environmentals was
to handle those packages that currently need the X11 includes passed
on CFLAGS rather than CPPFLAGS.
% grep -R X11 * | grep CFLAGS | grep info
gnome/gedit.info:ConfigureParams: --disable-static
--disable-scrollkeeper --disable-schemas-install --mandir=%p/share/man
--libexecdir=%p/lib --enable-dependency-tracking
PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
PYTHON=%p/bin/python2.7 F77=no --enable-gtk-doc EGG_SMCLIENT_CFLAGS="
" EGG_SMCLIENT_LIBS="-L/usr/X11R6/lib -lSM -lICE -lX11"
--disable-silent-rules X11_CFLAGS=" " X11_LIBS=" "
gnome/gnome-games.info: SMCLIENT_CFLAGS=" " SMCLIENT_LIBS="-lSM -lICE
-L/usr/X11/lib -L/usr/X11R6/lib" \
gnome/gnome-session.info:ConfigureParams: --mandir=%p/share/man
--disable-docbook-docs --disable-schemas-install
--enable-dependency-tracking --disable-static
PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
--x-i=/usr/X11R6/include --x-l=/usr/X11R6/lib SM_CFLAGS=" "
SM_LIBS="-lSM -L/usr/X11/lib -L/usr/X11R6/lib" ICE_CFLAGS=" "
ICE_LIBS=-lICE XTEST_CFLAGS=" " XTEST_LIBS=-lXtst XRENDER_CFLAGS=" "
XRENDER_LIBS=-lXrender SPLASH_CFLAGS=" " SPLASH_LIBS=" "
--disable-silent-rules
gnome/gnome-terminal.info:ConfigureParams: --disable-scrollkeeper
--disable-schemas-install --enable-dependency-tracking
--disable-static
PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
F77=no SMCLIENT_CFLAGS="-I/usr/X11/include -I/usr/X11R6/include"
SMCLIENT_LIBS="-lSM -lICE -lX11 -L/usr/X11/lib -L/usr/X11R6/lib"
gnome/gnome-utils.info: XSHAPE_CFLAGS=" " XSHAPE_LIBS="-lXext -lX11"
gnome/libgnomekbd2.info:ConfigureParams: --enable-schemas-install
--libexecdir=%p/lib/%n --mandir=%p/share/man
--enable-dependency-tracking
PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
--disable-static --x-libraries=/usr/X11R6/lib
--x-includes=/usr/X11R6/include DBUS_CFLAGS=" " DBUS_LIBS=" "
gnome/yelp.info: SMCLIENT_CFLAGS=" " SMCLIENT_LIBS="-lSM
-L/usr/X11/lib -L/usr/X11R6/lib" \
graphics/ffmpeg.info:SetCFLAGS: -I%p/lib/libspeex1/include
-I%p/include -I/usr/X11R6/include -MD
graphics/libavcodec53-shlibs.info:SetCFLAGS:
-I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
graphics/libavcodec54-0.11-shlibs.info:SetCFLAGS:
-I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
graphics/libavcodec54-1.0-shlibs.info:SetCFLAGS:
-I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
graphics/libavcodec54-1.2-shlibs.info:SetCFLAGS:
-I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
graphics/libavcodec55-2.0-shlibs.info:SetCFLAGS:
-I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
graphics/libavcodec56-2.4-shlibs.info:SetCFLAGS:
-I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
sci/xcircuit-testing.info:SetCFLAGS: -I/usr/X11/include -fno-common
sci/xcircuit-testing.info:Added -I/usr/X11/include to CFLAGS because
it wouldn't work with
sci/xcircuit.info:SetCFLAGS: -I/usr/X11/include -fno-common
sci/xcircuit.info:Added -I/usr/X11/include to CFLAGS because it
wouldn't work with
utils/expect-10.10.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
utils/expect-10.9.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
utils/expect.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
x11/freeglut.info:SetCFLAGS: -O3 -DTARGET_HOST_POSIX_X11 -I%p/include
-I/usr/X11R6/include
x11/openmotif3.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
-DXNO_MTSAFE_STRINGAPI -DXNO_MTSAFE_PWDAPI -DXNO_MTSAFE_TIMEAPI -O2 -g
x11/openmotif3.info: ./configure %c X_CFLAGS="-I%p/include
-I/usr/X11R6/include" X_LIBS="-L%p/lib -L/usr/X11R6/lib"
x11/openmotif4.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
-DXNO_MTSAFE_STRINGAPI -DXNO_MTSAFE_PWDAPI -DXNO_MTSAFE_TIMEAPI
Likewise, some of the 107 usages of --x-includes=/usr/X11R6/include in
the current package set may still be required if those are due to
their configure scripts testing internally for X11 header support
using CFLAGS rather than CPPFLAGS.
Jack
On Tue, Feb 10, 2015 at 10:14 PM, Alexander Hansen
<alexanderk.han...@gmail.com> wrote:
>
> On Feb 10, 2015, at 6:44 PM, Jack Howarth <howarth.at.f...@gmail.com> wrote:
>
> Hanspeter,
> Now that a working implementation for the automatic appending of
> the appropriate X11 include and linker flags to CPPFLAGS and LDFLAGS
> has been checked in to fink git...
>
> http://sourceforge.net/p/fink/patches/158/
>
>
> It’s in a branch covered by a pull request.
>
> And before we call it “working”, I’d like to verify that it works _in all
> aspects_. For example, does your automatic implementation give the right
> results from “fink dumpinfo -eLDFLAGS <packagename>” and “fink dumpinfo
> -eCPPFLAGS <packagename>” for packages that BuildDepend on x11-dev?
>
>
> we need the to implement the other half required for fully migrating
> off of depending on the X11 convenience symlinks. If you can enhance
> the existing fink-buildenv-modules.info to provide build time
> variables for XORG_INCL_PATH and XORG_LINK_PATH which would be
> conditionally set to
>
> XORG_INCL_PATH=/usr/X11/include
> XORG_LIB_PATH=/usr/X11/lib
>
> when the running OS is darwin11 or earlier and
>
> XORG_INCL_PATH=/opt/X11/include
> XORG_LIB_PATH=/opt/X11/lib
>
> otherwise, this would allow package maintainers to stop hard-coding in
> the fully deprecated /usr/X11R based paths and the partially
> deprecated /usr/X11 paths.
> Jack
>
>
> Please elaborate upon why just allowing individual .info to set CPPFLAGS and
> LDFLAGS based on XORG_INCL_PATH and XORG_LIB_PATH from fink-buildenv-modules
> isn’t sufficient. Having the environment get set by default by fink is
> less transparent to maintainers than doing it in individual .info files.
>
> --
> Alexander Hansen, Ph.D.
> Fink User Liaison
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel
