> On Feb 11, 2015, at 4:04 AM, Jack Howarth <howarth.at.f...@gmail.com> wrote:
>
> On Tue, Feb 10, 2015 at 11:47 PM, Alexander Hansen
> <alexanderk.han...@gmail.com <mailto:alexanderk.han...@gmail.com>> wrote:
>>
>>> On Feb 10, 2015, at 8:17 PM, Jack Howarth <howarth.at.f...@gmail.com> wrote:
>>>
>>> Alexander,
>>> The rational for the request to add these new environmentals was
>>> to handle those packages that currently need the X11 includes passed
>>> on CFLAGS rather than CPPFLAGS.
>>>
>>> % grep -R X11 * | grep CFLAGS | grep info
>>> gnome/gedit.info:ConfigureParams: --disable-static
>>> --disable-scrollkeeper --disable-schemas-install --mandir=%p/share/man
>>> --libexecdir=%p/lib --enable-dependency-tracking
>>> PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
>>> PYTHON=%p/bin/python2.7 F77=no --enable-gtk-doc EGG_SMCLIENT_CFLAGS="
>>> " EGG_SMCLIENT_LIBS="-L/usr/X11R6/lib -lSM -lICE -lX11"
>>> --disable-silent-rules X11_CFLAGS=" " X11_LIBS=" "
>>> gnome/gnome-games.info: SMCLIENT_CFLAGS=" " SMCLIENT_LIBS="-lSM -lICE
>>> -L/usr/X11/lib -L/usr/X11R6/lib" \
>>> gnome/gnome-session.info:ConfigureParams: --mandir=%p/share/man
>>> --disable-docbook-docs --disable-schemas-install
>>> --enable-dependency-tracking --disable-static
>>> PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
>>> --x-i=/usr/X11R6/include --x-l=/usr/X11R6/lib SM_CFLAGS=" "
>>> SM_LIBS="-lSM -L/usr/X11/lib -L/usr/X11R6/lib" ICE_CFLAGS=" "
>>> ICE_LIBS=-lICE XTEST_CFLAGS=" " XTEST_LIBS=-lXtst XRENDER_CFLAGS=" "
>>> XRENDER_LIBS=-lXrender SPLASH_CFLAGS=" " SPLASH_LIBS=" "
>>> --disable-silent-rules
>>> gnome/gnome-terminal.info:ConfigureParams: --disable-scrollkeeper
>>> --disable-schemas-install --enable-dependency-tracking
>>> --disable-static
>>> PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
>>> F77=no SMCLIENT_CFLAGS="-I/usr/X11/include -I/usr/X11R6/include"
>>> SMCLIENT_LIBS="-lSM -lICE -lX11 -L/usr/X11/lib -L/usr/X11R6/lib"
>>> gnome/gnome-utils.info: XSHAPE_CFLAGS=" " XSHAPE_LIBS="-lXext -lX11"
>>> gnome/libgnomekbd2.info:ConfigureParams: --enable-schemas-install
>>> --libexecdir=%p/lib/%n --mandir=%p/share/man
>>> --enable-dependency-tracking
>>> PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:%p/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH"
>>> --disable-static --x-libraries=/usr/X11R6/lib
>>> --x-includes=/usr/X11R6/include DBUS_CFLAGS=" " DBUS_LIBS=" "
>>> gnome/yelp.info: SMCLIENT_CFLAGS=" " SMCLIENT_LIBS="-lSM
>>> -L/usr/X11/lib -L/usr/X11R6/lib" \
>>> graphics/ffmpeg.info:SetCFLAGS: -I%p/lib/libspeex1/include
>>> -I%p/include -I/usr/X11R6/include -MD
>>> graphics/libavcodec53-shlibs.info:SetCFLAGS:
>>> -I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
>>> graphics/libavcodec54-0.11-shlibs.info:SetCFLAGS:
>>> -I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
>>> graphics/libavcodec54-1.0-shlibs.info:SetCFLAGS:
>>> -I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
>>> graphics/libavcodec54-1.2-shlibs.info:SetCFLAGS:
>>> -I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
>>> graphics/libavcodec55-2.0-shlibs.info:SetCFLAGS:
>>> -I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
>>> graphics/libavcodec56-2.4-shlibs.info:SetCFLAGS:
>>> -I%p/lib/libspeex1/include -I%p/include -I/usr/X11R6/include -MD
>>> sci/xcircuit-testing.info:SetCFLAGS: -I/usr/X11/include -fno-common
>>> sci/xcircuit-testing.info:Added -I/usr/X11/include to CFLAGS because
>>> it wouldn't work with
>>> sci/xcircuit.info:SetCFLAGS: -I/usr/X11/include -fno-common
>>> sci/xcircuit.info:Added -I/usr/X11/include to CFLAGS because it
>>> wouldn't work with
>>> utils/expect-10.10.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
>>> utils/expect-10.9.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
>>> utils/expect.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
>>> x11/freeglut.info:SetCFLAGS: -O3 -DTARGET_HOST_POSIX_X11 -I%p/include
>>> -I/usr/X11R6/include
>>> x11/openmotif3.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
>>> -DXNO_MTSAFE_STRINGAPI -DXNO_MTSAFE_PWDAPI -DXNO_MTSAFE_TIMEAPI -O2 -g
>>> x11/openmotif3.info: ./configure %c X_CFLAGS="-I%p/include
>>> -I/usr/X11R6/include" X_LIBS="-L%p/lib -L/usr/X11R6/lib"
>>> x11/openmotif4.info:SetCFLAGS: -I%p/include -I/usr/X11R6/include
>>> -DXNO_MTSAFE_STRINGAPI -DXNO_MTSAFE_PWDAPI -DXNO_MTSAFE_TIMEAPI
>>>
>>> Likewise, some of the 107 usages of --x-includes=/usr/X11R6/include in
>>> the current package set may still be required if those are due to
>>> their configure scripts testing internally for X11 header support
>>> using CFLAGS rather than CPPFLAGS.
>>> Jack
>>>
>>> On Tue, Feb 10, 2015 at 10:14 PM, Alexander Hansen
>>
>> I’ll rephrase my original question for clarity:
>>
>> Taking new, platform-portable environment variables from an updated
>> fink-buildenv-modules as given for the sake of argument, why would we also
>> need to add your proposed change to fink’s internal environment settings?
>> It is a heck of a lot more flexible and transparent to let individual
>> packages to set their own LDFLAGS and CPPFLAGS rather than relying on fink
>> to do so.
>>
>
> Okay, lets proceed with the platform-portable environment variables
> from an updated fink-buildenv-modules approach first and put the
> auto-append approach on hold.
>
>> Is there a reason that the X11 include and library directories _must_ be set
>> in the fink code? Historically, it’s often been the case that setting
>> things globally for fink rather than in individual .infos winds up not
>> working out well. The tweak to allow unknown arguments to clang-5 which
>> became nonfunctional in clang-6 stands to mind.
>
> Agreed, lets put the auto-append approach aside for the moment.
>
Yeah, if auto-append isn’t strictly necessary I’d say hold off. It’s a lot
more involved and potentially perilous.
Technically we don’t even need to use fink-buildenv-modules. It’s certainly
possible for individual packages to do this kind of thing themselves in their
own CompileScripts. I’m not saying this is preferred, since there’s a lot of
reinvention of the wheel and the potential for something not to do it right,
but it’s certainly a possibility for a quick changeover if a maintainer so
desires.
--
Alexander Hansen, Ph.D.
Fink User Liaison
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel
