On Tue, Feb 10, 2015 at 10:14 PM, Alexander Hansen
<alexanderk.han...@gmail.com> wrote:
>
> On Feb 10, 2015, at 6:44 PM, Jack Howarth <howarth.at.f...@gmail.com> wrote:
>
> Hanspeter,
>      Now that a working implementation for the automatic appending of
> the appropriate X11 include and linker flags to CPPFLAGS and LDFLAGS
> has been checked in to fink git...
>
> http://sourceforge.net/p/fink/patches/158/
>
>
> It’s in a branch covered by a pull request.
>
> And before we call it “working”, I’d like to verify that it works _in all
> aspects_.  For example, does your automatic implementation give the right
> results from “fink dumpinfo -eLDFLAGS <packagename>” and “fink dumpinfo
> -eCPPFLAGS <packagename>” for packages that BuildDepend on x11-dev?
>
>
Alexander,
  The current code path used during the execution of  'fink dumpinfo -eLDFLAGS'
and 'fink dumpinfo -eCPPFLAGS' won't be able to detect this auto-append as
the test for the presence of the BuildDepends on x11-dev must be done in
resolve_depends() when the dependencies are being collated.

My tests have been done brute force by adding...

echo $CPPFLAGS;
echo $LDFLAGS;

at the front of the CompileScript in xft2-dev. which on darwin14 produces...

echo $CPPFLAGS;
-I/sw/include -I/opt/X11/lib
echo $LDFLAGS;
-L/sw/lib -L/opt/X11/lib

in the build log while...

% fink dumpinfo -eCPPFLAGS xft2-dev
Scanning package description files..........
Information about 10430 packages read in 2 seconds.
CPPFLAGS=-I/sw/include

% fink dumpinfo -eLDFLAGS xft2-dev
Scanning package description files..........
Information about 10430 packages read in 1 seconds.
LDFLAGS=-L/sw/lib

                 Jack



> we need the to implement the other half required for fully migrating
> off of depending on the X11 convenience symlinks. If you can enhance
> the existing fink-buildenv-modules.info to provide build time
> variables for XORG_INCL_PATH and XORG_LINK_PATH which would be
> conditionally set to
>
> XORG_INCL_PATH=/usr/X11/include
> XORG_LIB_PATH=/usr/X11/lib
>
> when the running OS is darwin11 or earlier and
>
> XORG_INCL_PATH=/opt/X11/include
> XORG_LIB_PATH=/opt/X11/lib
>
> otherwise, this would allow package maintainers to stop hard-coding in
> the fully deprecated /usr/X11R based paths and the partially
> deprecated /usr/X11 paths.
>       Jack
>
>
> Please elaborate upon why just allowing individual .info to set CPPFLAGS and
> LDFLAGS based on XORG_INCL_PATH and XORG_LIB_PATH from fink-buildenv-modules
> isn’t sufficient.   Having the environment get set by default by fink is
> less transparent to maintainers than doing it in individual .info files.
>
> --
> Alexander Hansen, Ph.D.
> Fink User Liaison
>j

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel

Reply via email to