On 4/22/06, Philip Ganchev <[EMAIL PROTECTED]> wrote: > On 4/21/06, Axel Liljencrantz <[EMAIL PROTECTED]> wrote: > > On 4/21/06, Axel Liljencrantz <[EMAIL PROTECTED]> wrote: > [...] > > While implementing the suggested new messages, I ended up changing > > them quite a bit in order to provide the user with more information > > about how to proceed. > > Awesome! > > Small modification suggestion: > > fish> $PWD > fish: Variables may not be used as commands. Instead, define a function like > 'function PWD; /mnt/home/axel/code/c/fish_current $argv; end'. > See the help section for the function command by typing 'help function'. > > I removed the phrase "For more information", as it only adds > verbosity. It is clear that you are being referred to another source > of information. And I moved "instead" to the start of the sentence to > connect it to the previous sentence from a shorter range.
Thanks for the suggenstions! I've dropped the 'For more information' bit from all the places where it's used, and moved the 'instead' as well. > > Would it be terrible if the error message also printed the value of > variable PWD? They do! The body of the suggested fundtion is the value of PWD. > > [...] > > > > fish> function say!hello; echo hello; end > > > > fish: Invalid character '!' in function name. Only alphabetic and > > > > numeric characters and underscore are valid. > > > > > > > > Since posix does not prevent filenames from containing a '!', I think > > this error is misleading. There could have been a command called > > 'say!hello' and it would run just fine. > > But Fish prevents functions from containing a '!', which is just what > the messages says. You can't define a function called 'say!hello'. True, but doesn't the message imply that because functions dialow it, that this is an illegal command name, when the truth is that a regular command may contain a '!'. Remember for example that there is a '[' command. That is not a legal function name. The real problem is simply that a command with the specified name doesn't exist. The fact thatthe given command name is also not a legal function name is not the main problem. > > > > At the suggestion of another user in a private mail, I've also added > > checks to make sure that PATH, CDPATH and friends only contain actual > > directories, which allows us to show an error message like this when a > > user is using the PATH as if it was a colon-separated list and not an > > array: > > > > fish> set PATH $PATH:. > > set: Could not add component /usr/local/bin:. to PATH. > > set: No such file or directory > > set: Did you mean 'set PATH $PATH .'? > > Nice! > :) -- Axel ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
