Thanks! I got your version now. git seems pretty nice. Anyway, the problem was in config.h - I have to comment out the HAVE_REALPATH_NULL: include/config.h:/*#define HAVE_REALPATH_NULL 1*/
I'm using OSX 10.5.8, I don't know why my realpath can't handle NULL. I think two additional fixes are needed: 1. in kill.c, add the option '-n' to echo, so that fish doesn't add an extra newline to what's copied to the buffers. 2. in fish.c add + to the getopt: #define GETOPT_STRING "+hilnvc:p:d:" That tells fish to stop reading arguments when it encounters a non- option. That caused a bug in seq, but it'll cause a bug in any fish script that has to accept options or negative numbers. Michael On 2 Apr 2010, at 15:53, David Frascone wrote: > What OS are you using? Also, Ben has not pulled my changes yet, so, > you can either apply my patches by hand, or pull from my tree: > > git clone git://github.com/CodeMonk/fish.git > > -Dave > > On Fri, Apr 2, 2010 at 7:07 AM, Michael Lachmann > <[email protected]> wrote: > I tried to download using git, but I'm getting an error, and I'm not > sure what I did wrong. > > I did this: > git clone git://github.com/benhoskings/fish > cd fish > ./configure > make > sudo make install > > but, calling fish gives me an error: > ~/D/f/fish> /usr/local/bin/fish > fish: Job 1, '/usr/local/bin/fish' terminated by signal SIGBUS > (Misaligned address error) > > ? > > On 2 Apr 2010, at 13:03, David Frascone wrote: > > > Right. I was in the same boat. Use my patch and the fish installed > > seq will work for you. > > > > -Dave > > > > Sent from my iPhone > > > > On Apr 2, 2010, at 4:52 AM, Michael Lachmann <[email protected]> > > wrote: > > > >> The seq that I use is /sw/bin/seq, which seems to have been > installed > >> by fish: > >> --- > >> #!/usr/bin/env fish > >> # > >> # Fallback implementation of the seq command > >> # > >> # seq. Generated from seq.in by configure. > >> > >> set -l from 1 > >> . > >> . > >> . > >> --- > >> > >> The error (fish: invalid option -- 1) seems to be generated before > >> the script is ever called, by fish itself. > >> So, when the script is invoked, fish is called, with the arguments > >> (10 > >> -1 5), and it generates the error. > >> > >> I think when fish is invoked for a script, it shouldn't parse the > >> arguments that are meant for the script... > >> > >> Michael > >> > >> > >> On 2 Apr 2010, at 8:09, Isaac Dupree wrote: > >> > >>> On 04/02/10 01:31, David Frascone wrote: > >>>> Found and fixed. There were several issues. First, most people > >>>> who type > >>>> seq are really running seq on their host. Fish will only use the > >>>> builtin if > >>>> it doesn't find it locally. Use 'seq --version' to see what I > >>>> mean. > >>> > >>> of course seq is /usr/bin/seq ! (or wherever it is on your path.) > >>> What > >>> does it have to do with Fish? How can Fish have a possibly-a- > >>> builtin, > >>> possibly-not?(for me, 'type seq' just says 'seq is /usr/bin/ > >>> seq' ...) > >>> Isn't it against Fish's philosophy to duplicate external tools > that > >>> don't need to be built into a shell? > >>> > >>> Is Mac OS X 'seq' broken, under-featured, (or nonexistent?)? I > >>> would be > >>> unsurprised. In 10.3 (the last version I used regularly), I know > >>> they > >>> shipped a version of 'find' that enjoyed segfaulting (or some > weird > >>> error, I forget exactly) when you forgot that their version of the > >>> 'find' command didn't support omitting the path bit (you had to > pass > >>> '.'). Admittedly, I think they just copied the tools from BSD, but > >>> that > >>> doesn't mean they were good tools... > >>> > >>> -Isaac > >>> > >>> > ------------------------------------------------------------------------------ > >>> Download Intel® Parallel Studio Eval > >>> Try the new software tools for yourself. Speed compiling, find > bugs > >>> proactively, and fine-tune applications for parallel performance. > >>> See why Intel Parallel Studio got high marks during beta. > >>> http://p.sf.net/sfu/intel-sw-dev > >>> _______________________________________________ > >>> Fish-users mailing list > >>> [email protected] > >>> https://lists.sourceforge.net/lists/listinfo/fish-users > >>> > >> > >> > >> > ------------------------------------------------------------------------------ > >> Download Intel® Parallel Studio Eval > >> Try the new software tools for yourself. Speed compiling, find bugs > >> proactively, and fine-tune applications for parallel performance. > >> See why Intel Parallel Studio got high marks during beta. > >> http://p.sf.net/sfu/intel-sw-dev > >> _______________________________________________ > >> Fish-users mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/fish-users > > > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Fish-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/fish-users > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
