Hi Mark,
Thanks for the article!
A few comments below:
Installing:
> Search that page for "Go f
Some text missing?
Default Shell:
If you can't change /etc/shells, you should be able to arrange to have your
shell execute fish as a login shell via the -l switch. For example, if your
shell is bash, then add the following to the top of your ~/.bash_profile:
# fish installed to $HOME/local/bin/fish
[ -x $HOME/local/bin/fish ] && exec $HOME/local/bin/fish -l
Autosuggestions
I think it's worth mentioning that fish is far more aggressive in providing
suggestions than other shells (pressing tab is not required), and the
suggestions provided by default are much comprehensive than that of other
shells.
For example, fish will not only complete environment variables and command
line switches, but also git aliases (~/.gitconfig is parsed) and the npm
scripts (package.json is parsed).
PATH environment variable
> fish_user_paths should only be set in a terminal, not in config.fish.
Why is this?
Strings
> is equal to another: if "$var1" = "$var2"
This doesn't work. I think you want a "test" in there?
Michael
On Fri, Oct 6, 2017 at 6:41 PM, Mark Volkmann <r.mark.volkm...@gmail.com>
wrote:
> On Fri, Oct 6, 2017 at 10:47 AM, Glenn Jackman <jack...@pythian.com>
> wrote:
>
>> Great work.
>>
>
> Thanks!
>
>
>> Some feedback
>>
>> * POSIX is all caps: should be fixed at fish site too
>>
>
> Fixed in article.
>
>
>> * uninstalling: note that /usr/local/bin is the default directory. Users
>> should definitely verify fish is actually there before `rm -rf`
>>
>
> I added a note about verifying that fish was installed under /usr/local
> and adjusting the paths if not.
>
>
>> * I did not know about `man fish_command`: +1
>> * Dates:
>> * this is not fish-specific at all. Why is it here? Perhaps move it
>> to the Extras section
>>
>
> I moved it there.
>
>
>> * `strftime` is not a command, it is a system library function for
>> writing C code.
>>
>
> Fixed.
>
>
>> I cannot speak to the intent of the fish designers, but fish seems to
>> have borrowed (in the best sense of the word) some ideas from the Tcl
>> language. Particular the idea of `command subcommand args...`. It's
>> interesting to compare [the fish string command](https://fishshell.com
>> /docs/current/commands.html#string) with [the Tcl string command](
>> https://tcl.tk/man/tcl8.6/TclCmd/string.htm). Tcl was one of my very
>> first languages, and I have an enduring love for it: seeing Tcl-ish
>> tendencies growing in fish warms my heart.
>>
>
> Thanks so much for the feedback!
>
> --
> R. Mark Volkmann
> Object Computing, Inc.
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Fish-users mailing list
> Fish-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/fish-users
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users
