Thanks so much for taking the time to review this! See my replies inline
below.
On Fri, Oct 27, 2017 at 10:57 PM, Michael Stillwell <m...@beebo.org> wrote:
> Hi Mark,
>
> Thanks for the article!
>
> A few comments below:
>
> Installing:
>
> > Search that page for "Go f
>
> Some text missing?
>
Yes. That was supposed to say:
Search that page for "Go fish".
I fixed it.
> Default Shell:
>
> If you can't change /etc/shells, you should be able to arrange to have
> your shell execute fish as a login shell via the -l switch. For example, if
> your shell is bash, then add the following to the top of your
> ~/.bash_profile:
>
> # fish installed to $HOME/local/bin/fish
> [ -x $HOME/local/bin/fish ] && exec $HOME/local/bin/fish -l
>
Can you tell me why the installer or a person would not be able to edit
/etc/shells? I imagine you're referring to a permission issue. I'm not sure
how common that is. Should I really mention this approach of keeping bash
as the default shell, but having it immediately switch to fish?
> Autosuggestions
>
> I think it's worth mentioning that fish is far more aggressive in
> providing suggestions than other shells (pressing tab is not required), and
> the suggestions provided by default are much comprehensive than that of
> other shells.
>
I'm adding this:
"without requiring another key like tab to be pressed."
About being more aggressive, the article says this:
It derives suggestions from command history,
possible commands, possible switches,
variables, and file paths.
For example, fish will not only complete environment variables and command
> line switches, but also git aliases (~/.gitconfig is parsed) and the npm
> scripts (package.json is parsed).
>
I can't get autosuggestions to work with npm scripts. I have to press tab
to get those completions. Does it really suggest those for your without
pressing tab? For example, my package.json contains scripts for "start",
"build", and "test". When I type "npm run b" it does not suggest "build",
but it does if I press tab. However, after I run "npm run build" once then
it will suggest that from just "npm run b". But that is happening because
the command is now in my command history.
> PATH environment variable
>
> > fish_user_paths should only be set in a terminal, not in config.fish.
>
> Why is this?
>
I got that from https://fishshell.com/docs/current/tutorial.html where is
says this:
A faster way is to modify the $fish_user_paths universal variable
<https://fishshell.com/docs/current/tutorial.html#tut_universal>, which is
automatically prepended to $PATH. For example, to permanently add
/usr/local/bin to your $PATH, you could write:
> set -U fish_user_paths /usr/local/bin $fish_user_paths
The advantage is that you don't have to go mucking around in files: just
run this once at the command line, and it will affect the current session
and all future instances too. (Note: you should NOT add this line to
config.fish. If you do, the variable will get longer each time you run
fish!)
> Strings
>
> > is equal to another: if "$var1" = "$var2"
>
> This doesn't work. I think you want a "test" in there?
>
Thanks! Good catch!
--
R. Mark Volkmann
Object Computing, Inc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users
